AlexStocks commented on code in PR #1017: URL: https://github.com/apache/dubbo-go-pixiu/pull/1017#discussion_r3829399353
########## tools/benchmark/README_CN.md: ########## @@ -1,70 +1,38 @@ # Benchmark 结果 -* dubbo: +测试环境：macOS、Apple Silicon，每个方法 500 次采样。Dubbo、gRPC、Triple 三套测试并行运行。 -``` -dubbo protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - ===================================================================== - GetUser [duration] | 500 | 100µs | 200µs | 600µs | 2.8ms | 20.7ms - --------------------------------------------------------------------- - GetGender [duration] | 500 | 0s | 100µs | 200µs | 100µs | 600µs - --------------------------------------------------------------------- - GetUser0 [duration] | 500 | 100µs | 100µs | 200µs | 0s | 400µs - --------------------------------------------------------------------- - GetUsers [duration] | 500 | 100µs | 200µs | 200µs | 100µs | 600µs - --------------------------------------------------------------------- - GetUser2 [duration] | 500 | 0s | 200µs | 200µs | 100µs | 500µs - --------------------------------------------------------------------- - GetErr [duration] | 500 | 300µs | 500µs | 500µs | 200µs | 1.4ms - - pixiu to dubbo protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - ==================================================================== - GetUser [duration] | 500 | 200µs | 600µs | 1.8ms | 8.4ms | 61ms - -------------------------------------------------------------------- - GetGender [duration] | 499 | 200µs | 500µs | 600µs | 300µs | 4.1ms - -------------------------------------------------------------------- - GetUser0 [duration] | 497 | 200µs | 500µs | 600µs | 300µs | 2.5ms - -------------------------------------------------------------------- - GetUsers [duration] | 495 | 200µs | 600µs | 700µs | 300µs | 2.9ms -``` +## Dubbo -* grpc: +| 方法 | Min | Median | Mean | StdDev | Max | +| --- | --- | --- | --- | --- | --- | +| GetUser（经 Pixiu） | 200µs | **400µs** | 600µs | 1.5ms | 14.2ms | +| GetGender（经 Pixiu） | 200µs | **300µs** | 400µs | 500µs | 4.3ms | +| GetUser0（经 Pixiu） | 200µs | 400µs | 400µs | 200µs | 1.6ms | +| GetUsers（经 Pixiu） | 200µs | 400µs | 400µs | 200µs | 1.7ms | +| GetUser（直连） | 100µs | 200µs | 200µs | 100µs | 500µs | -``` -grpc protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - ======================================================================== - GetUser [duration] | 500 | 100µs | 300µs | 400µs | 600µs | 5.2ms - ------------------------------------------------------------------------ - GetUsers [duration] | 500 | 100µs | 300µs | 300µs | 200µs | 1.5ms - ------------------------------------------------------------------------ - GetUserByName [duration] | 496 | 100µs | 200µs | 300µs | 100µs | 1ms - -pixiu to grpc protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - ========================================================================= - GetUser [duration] | 500 | 600µs | 2ms | 3.4ms | 4.3ms | 25.9ms - ------------------------------------------------------------------------- - GetUsers [duration] | 500 | 600µs | 1.3ms | 2.1ms | 3.3ms | 25.1ms - ------------------------------------------------------------------------- - GetUserByName [duration] | 500 | 800µs | 1.9ms | 2.7ms | 3.8ms | 33.4ms -``` +对比 issue #820 中的 Dubbo 数据：GetUser `600µs → 400µs`（约 1.5x），GetGender `500µs → 300µs`（约 1.7x）。 -* triple: +## gRPC -``` -triple protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - =================================================================== - SayHello [duration] | 500 | 100µs | 200µs | 300µs | 300µs | 2.6ms - -pixiu to triple protocol performance test - Name | N | Min | Median | Mean | StdDev | Max - ==================================================================== - SayHello [duration] | 490 | 10.1ms | 12.7ms | 14ms | 4.1ms | 43.3ms -``` +| 方法 | Min | Median | Mean | StdDev | Max | +| --- | --- | --- | --- | --- | --- | +| GetUser（经 Pixiu） | 200µs | **600µs** | 800µs | 1.1ms | 8.3ms | +| GetUsers（经 Pixiu） | 200µs | **600µs** | 700µs | 400µs | 3.6ms | +| GetUserByName（经 Pixiu） | 200µs | 400µs | 500µs | 300µs | 2ms | +| GetUser（直连） | 100µs | 200µs | 200µs | 400µs | 2.8ms | + +## Triple + +| 方法 | Min | Median | Mean | StdDev | Max | +| --- | --- | --- | --- | --- | --- | +| GetUser（经 Pixiu） | 200µs | **500µs** | 600µs | 300µs | 2.5ms | Review Comment: [P2] 这里把 Triple 直连数据标成了“经 Pixiu”。英文表中 Triple Direct 的 `GetUser` 正是 `200µs / 500µs / 600µs`，而 Triple via Pixiu 的对应数据是 `200µs / 1ms / 1.5ms`；下一行 `GetUsers` 也同样取自 Direct。当前中文表因此重复了第 33 行的直连 `GetUser`，并把代理 median/mean 明显写低，会让这次性能结论与同 PR 的英文证据互相矛盾。请改用 via Pixiu 的实际结果或修正标签，并补一个从同一份 benchmark 输出生成/校验双语表格的检查，避免两份文档再次漂移。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
