Alanxtl commented on code in PR #3695: URL: https://github.com/apache/dubbo-go/pull/3695#discussion_r3849044653
########## registry/page.go: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package registry + +import ( + gxpage "github.com/dubbogo/gost/hash/page" +) + +// Pager is an alias of gxpage.Pager from github.com/dubbogo/gost/hash/page. +// It is kept as a type alias so that the signatures of the exported +// ServiceDiscovery pagination methods stay source-compatible for external +// implementors across the v3.x line. +type Pager = gxpage.Pager + +// NewPage will create a Pager instance. +func NewPage(requestOffset int, pageSize int, data []any, totalSize int) Pager { + return gxpage.NewPage(requestOffset, pageSize, data, totalSize) +} Review Comment: 不用包一层了 这个我们不改了 就恢复原来的版本就行 ########## filter/adaptivesvc/limiter/hill_climbing.go: ########## Review Comment: 这个文件也维持原状 不修改了 ########## registry/service_instance.go: ########## @@ -236,11 +235,17 @@ func (d *DefaultServiceInstance) GetMetadata() map[string]string { return d.Metadata } +// Prioritizer is a Dubbo domain interface for objects that can be ordered by +// an integer priority. It replaces the former gost/sort.Prioritizer. Review Comment: provide a link links to the gost file ########## proxy/proxy.go: ########## @@ -203,8 +214,7 @@ func DefaultProxyImplementFunc(p *Proxy, v common.RPCService) { result := p.invoke.Invoke(invCtx, inv) err = result.Error() - // cause is raw user level error Review Comment: keep this comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
