jamespud commented on PR #16418: URL: https://github.com/apache/dubbo/pull/16418#issuecomment-5419484858
## 🚀 Ready for Review ### PR Summary Fixes ByteBuf memory leak in Triple client when responses arrive after executor shutdown. ### Testing - [x] Unit test added and passing - [x] Verified fix with: `testOnDataReleaseByteBufAfterCallbackExecutorShutdown` - [x] No regressions in existing tests ### Open Questions for Reviewers 1. Should we add metrics/alerting for dropped frames? 2. Does this fix apply to `AbstractTripleServerStream` as well? 3. Any compatibility concerns with older versions? @RainYuY @zrlw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
