skrcode opened a new pull request, #16442:
URL: https://github.com/apache/dubbo/pull/16442

   ## What is the purpose of the change?
   
   This companion PR completes the MCP SDK 0.18.3 upgrade in #16342. The SDK 
replaced its Jackson-specific APIs with `McpJsonMapper`/`TypeRef` and removed 
the deprecated string-schema `Tool` constructors, leaving the Dependabot head 
unable to compile.
   
   The change:
   
   - adapts Dubbo's existing `ObjectMapper` instances through the SDK-provided 
`JacksonMcpJsonMapper`;
   - uses the SDK's new `TypeRef` transport contract;
   - migrates tool creation to the mapper-aware builder, preserving the 
previous JSON Schema parsing behavior; and
   - removes a redundant Mockito `@InjectMocks` path that constructed the SSE 
provider with a null mapper before the test's explicit setup.
   
   No public API or MCP wire behavior is intentionally changed.
   
   ## Verification
   
   - Reproduced 8 Java compilation errors on exact Dependabot head 
`09795dcd58e0137c63ea5307b025893cd1aa0c48` with `./mvnw -pl 
dubbo-plugin/dubbo-mcp -DskipTests compile`.
   - `./mvnw -T 4 -pl dubbo-plugin/dubbo-mcp -am clean install -DskipTests 
-Dmaven.javadoc.skip=true` — all 53 reactor modules passed Checkstyle, 
Spotless, compilation, packaging, and installation.
   - `./mvnw -pl dubbo-plugin/dubbo-mcp clean test verify -Pjacoco 
-DskipTests=false -DskipIntegrationTests=false -Dcheckstyle.skip=false 
-Dcheckstyle_unix.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true` — 89 
tests passed; JaCoCo report generated; zero Checkstyle violations; Spotless 
passed.
   - `git diff --check` passed.
   
   ## Checklist
   
   - [x] Make sure there is a 
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. 
(Dependency-upgrade context: #16342.)
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. Existing 
transport and tool-schema tests exercise the migrated paths; the SDK-dependent 
fixture was updated.
   - [x] Make sure GitHub Actions can pass. [Why the workflow is failing and 
how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to