AlexStocks commented on code in PR #1147: URL: https://github.com/apache/dubbo-go-samples/pull/1147#discussion_r3986417281
########## http3/internal/quic/quic_test.go: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package quic + +import ( + "strconv" + "testing" +) + +import ( + "dubbo.apache.org/dubbo-go/v3/protocol/triple" +) + +func TestOptions(t *testing.T) { Review Comment: `http3/go-client/cmd/main.go` 上尚未解决的 review 线程（Alanxtl，2026-09-11T02:16:25Z）要求的是「加集成测试的测试点，以验证 server 和 client 是否符合预期行为」，并明确「不是加单元测试」。本文件是本 Head 新增的测试，属后者：它验证 `Options()` 到 `triple.Options.Triple.Http3` 的字段映射，不启动 server/client，也不产生任何 RPC 往返，因此无法回答「server 与 client 行为是否符合预期」。 已核验的相关事实： 1. `start_integrate_test.sh` 的 `array` 中没有 `http3` 条目（对该文件检索 `http3` 无命中），即该 sample 目前没有任何集成测试测试点。`integrate_test.sh` 以 sample 目录为入参，新增测试点只需在 `array` 中追加 `http3`。 2. 该 thread 的 `isResolved=false`，且回复时间（2026-09-11T02:16:25Z）与 PR `updatedAt` 相同，即当前 Head 尚未回应该澄清。 需要区分的是：编译与格式已由 CI 覆盖 —— `.github/workflows/golangci-lint.yml` 启用了 `staticcheck` / `unused` / `govet`（均需类型检查全模块），本 Head 的 `lint` 检查为 success。所以这里不是编译风险，而是「调优参数在真实 QUIC 链路中是否生效」的行为覆盖缺口。 参考既有约定：samples 仓的集成测试点需要让 client 精确断言关键返回字段并以非零退出码报告失败（见 `integrate_test.sh`）。若 HTTP/3 因 TLS 证书等原因确实无法纳入 CI 矩阵，建议在该 thread 中说明原因并给出可复现的手工验证步骤，而不是仅以单元测试收口。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
