dodjdnh opened a new pull request, #1571: URL: https://github.com/apache/dubbo-admin/pull/1571
## Summary Fixes #1570. This PR addresses three Kubernetes deployment-manifest correctness issues: - Define `Namespace/dubbo-system` before the resources that use it. - Remove the two invalid `nodePort` fields from the Nacos `ClusterIP` Service. - Correct the Grafana service DNS in the Dubbo Admin ConfigMap. The change is contained in one commit, `cafc748bd51c730c7e1b9f2cdc135f8aed14667c` (`fix: correct Kubernetes deployment manifests`), and three files under `release/kubernetes/dubbo-system/`. ## Changes 1. Add `release/kubernetes/dubbo-system/00-namespace.yaml` to define `dubbo-system`. The filename places the Namespace before `dubbo-admin.yaml` and `nacos.yaml` when applying the directory with `kubectl apply -f release/kubernetes/dubbo-system`. 2. Keep the Nacos Service as `ClusterIP`, preserving its `port` and `targetPort` values while removing `nodePort: 30848` and `nodePort: 31848`. Its internal service address is unchanged. 3. Change the Admin ConfigMap Grafana URL from `http://grafana.monitoringg.svc:3000` to `http://grafana.monitoring.svc:3000`, matching the included Grafana Service. ## Validation - `git diff --check`: PASS. - The same external D002 deployment oracle checks A1 (Namespace definition), A2 (Namespace file precedes every manifest containing a `dubbo-system` namespaced resource), B1 (valid Nacos `ClusterIP` fields), B2 (Kubernetes server-side dry-run), and C (Grafana DNS). Before the filename correction it reported **A1 PASS, A2 FAIL, B1/B2/C PASS**; after the correction, **all five checks PASS**. A2 evaluates the actual file order rather than requiring a particular filename. - `kubectl apply --dry-run=client -f release/kubernetes/dubbo-system -o name` lists the Namespace before the Dubbo Admin and Nacos resources. - The Nacos manifest passes a Kubernetes API server-side dry-run; this is validation, not a real apply. A disposable Kubernetes cluster was not available, so a real fresh-cluster Deployment Smoke Test has **not** been performed. This PR does not claim that full deployment verification passed. ## Scope This PR does not change dashboard provisioning, Jaeger datasource setup, OTel Collector, Instance/Service Trace queries, log observability, or cross-signal navigation. **Areas affected** - [ ] Docs - [x] Installation - [ ] User Experience - [ ] Dubboctl - [ ] Console - [ ] Core Component -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
