CAICAIIs commented on PR #3752: URL: https://github.com/apache/dubbo-go/pull/3752#issuecomment-5866292790
The `Unit Test` check failed inside `protocol/triple/triple_protocol`: ``` --- FAIL: TestServer/http1/grpc/proto/cumsum_cancel_before_send --- FAIL: TestServer/http1/grpc/json_gzip/cumsum ``` That package is not affected by this change. Its tests build raw `tri.NewServer` instances and never go through `protocol/triple.Server`, which is the only server code touched here, and the change only adds a unary `$invoke` handler registration for IDL exports. I tried to attribute the failure on a Linux/amd64 machine, with the same commit this PR is based on (`302aa0e8`): | Run | Result | | --- | --- | | `develop` without this change, `go test ./protocol/triple/triple_protocol/ -run TestServer -count=1` (3 runs, isolated) | pass every time | | `develop` without this change, full-suite run, first attempt | pass | | `develop` without this change, full-suite run, second attempt | `TestUnflushableResponseWriter` fails | | this branch, full-suite run | `TestBidiStreamServerSendsFirstMessage`, then `TestBidiOverHTTP1` and `TestStreamForServer` | | this branch, `go test ./server/ -run TestIDLServiceServesGenericInvocation -count=5` | pass every time | The same package fails on unmodified `develop` under a full-suite run, with a different test name on each attempt, while the individual `TestServer` cases pass in isolation. That points to timing-sensitive streaming tests, not to the new registration. It would be good if someone with write access could re-run the failed job so the check reflects the actual state of this change. For reference, the affected packages are green locally and on that Linux machine: ``` ok dubbo.apache.org/dubbo-go/v3/protocol/triple ok dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol (repeated runs, isolated) ok dubbo.apache.org/dubbo-go/v3/filter/generic ok dubbo.apache.org/dubbo-go/v3/filter/generic/generalizer ok dubbo.apache.org/dubbo-go/v3/server ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
