lizining1231 commented on issue #3753:
URL: https://github.com/apache/dubbo-go/issues/3753#issuecomment-5870312237

   @CAICAIIs Thanks for reporting this and for providing the detailed 
reproduction and issue!
   
   When the peer finishes a stream before the client closes its request side, 
the final buffered flush may return `io.EOF`. The response-wait path already 
tolerated this condition, but `CloseRequest` returned the EOF directly even 
when the underlying `CloseWrite` succeeded. This could expose `unknown: EOF` to 
callers and replace the response status already sent by the peer.
   
   I have made the following fix and tested it:
   - Modified `CloseRequest` for gRPC and Triple to tolerate `io.EOF` from the 
final flush, while continuing to return other errors.
   - Added `TestCloseRequestIgnoresBufferedWriteEOF`, covering both protocol 
paths and verifying the fix.
   
   PR #3754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to