Similarityoung opened a new pull request, #1060:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1060

   **What this PR does**:
   
   gRPC backend calls omit the leading slash in the full method path. grpc-go 
v1.82.1 rejects these paths, causing the `grpc/reflection` integration tests to 
fail after the dependency update in #1058.
   
   Prefix the backend method with `/`, producing canonical paths such as 
`/echo.EchoService/Echo`. Add a regression test that inspects the method passed 
to `ClientConn.NewStream`, so the test also catches this defect with older gRPC 
versions that accept malformed paths.
   
   **Which issue(s) this PR fixes**:
   
   Related to #1058 and 
[grpc/grpc-go#8985](https://github.com/grpc/grpc-go/pull/8985).
   
   **Special notes for your reviewer**:
   
   Validation:
   - Confirmed the regression test fails before the fix with 
`echo.EchoService/Echo` instead of `/echo.EchoService/Echo`.
   - `go test -mod=readonly ./pkg/filter/network/grpcproxy/... -gcflags=-l 
-race`: passed, 105 tests across 2 packages.
   - `gofmt`, the repository import formatter, and `git diff --check`: passed.
   
   The test observes the real gRPC call boundary and stops before creating a 
transport stream; it requires no network access.
   
   **Does this PR introduce a user-facing change?**:
   
   ```release-note
   gRPC proxy backend calls now use canonical RPC method paths, allowing them 
to work with gRPC servers that enforce strict path validation.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to