28Hus commented on PR #1061:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1061#issuecomment-5968661021

   感谢 @AlexStocks 的仔细审阅。三条意见已在 57d68e0 中处理:
   1. 按仓库约定拆分了测试文件的 import 分组;本地运行 go tool imports-formatter 后,git diff 
--exit-code 无差异。
   2. 在 Pixiu-Admin 的中英文部署指南中补充了密钥缺失、重启失效、多副本共享密钥及不安全显式密钥会导致启动失败的说明,并统一了 
Compose 命令。
   3. 启动测试现在检查具体的密钥配置错误,并断言配置和日志全局状态未在密钥校验前改变。
   定向测试、auth race 检查和相关包 go vet 已在本地通过。新一轮 GitHub Actions 
目前显示需要维护者批准运行,因此我还不能声称远端单测已通过。烦请有权限的维护者批准工作流;运行后我会继续核对结果。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to