shangxinxiaolin opened a new pull request, #3762:
URL: https://github.com/apache/dubbo-go/pull/3762

   ### Description
   
   Fixes #3761
   
   Track visited pointers only on the active recursion path. Previously, the 
traversal-wide set treated repeated references to a shared non-cyclic object as 
cycles and silently replaced subsequent values with nil. Remove each pointer 
from the set when its conversion returns; actual ancestor cycles continue to be 
truncated.
   
   Add three public-API round-trip cases for shared pointers in struct fields, 
slice elements and map values. All fail before the fix and pass afterwards; 
existing self-cycle and mutual-cycle tests remain passing. Value contents are 
preserved; pointer identity is not asserted.
   
   ### Validation (performed before GitHub submission)
   
   - `go test ./filter/generic/... -count=1` — passed.
   - `go vet ./filter/generic/...` — passed.
   - `make fmt` — passed in an isolated worktree; no tracked content 
differences after line-ending normalization.
   - `make test` — root suite completed with failures. AccessLog's hard-coded 
`/tmp/test_access_log.log` and four Triple occupied-port error assertions fail 
on Windows; all five also reproduced on base commit `5cfd927a`. This run 
additionally failed `TestDubboProtocol_Export` because port 20000 was occupied; 
that additional failure has not been base-reproduced. Full-suite success is not 
claimed.
   - `go test ./...` in `tools/dubbogo-cli` — passed separately (Make stopped 
before its CLI step).
   
   Environment: Windows amd64, Go 1.25.5, Git Bash, GNU Make 4.4.1; 
process-local `GOPROXY=https://goproxy.cn,direct`.
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] I have run `make fmt` to format my code
   - [ ] I have run `make test` to run local tests (executed, but failed as 
detailed above)
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to