AsperforMias commented on PR #1552: URL: https://github.com/apache/dubbo-admin/pull/1552#issuecomment-6201141196
LGTM for the resource/YAML-codec scope at `d9a60d1`. Rechecked boolean field presence, non-empty rule validation, and the Affinity/Script nil-Spec guards. The package tests, race check, and my original nil-Spec reproducer all pass: ```text go test ./pkg/core/resource/apis/mesh/v1alpha1 ./pkg/common/constants go test -race ./pkg/core/resource/apis/mesh/v1alpha1 ``` The Script execution timeout remains tracked separately in apache/dubbo-go#3566 / apache/dubbo-go#3575. The configuration-center path-precedence and API/history findings remain with #1553 and #1554. This LGTM applies to #1552's resource/codec scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
