AsperforMias opened a new issue, #3767:
URL: https://github.com/apache/dubbo-go/issues/3767

   ### What problem would this solve?
   
   The observability slice of [OSPP 
262e80018](https://summer.ospp.ac.cn/org/prodetail/262e80018?list=org&navpage=org&lang=zh)
 requires Go core RPC metrics to be consumable by Admin and basic trace entries 
to work. The concrete Go-side handoff requested in 
[#3562](https://github.com/apache/dubbo-go/issues/3562#issuecomment-5598910584) 
still needs a reproducible, versioned set of actual exported Metric/Trace 
samples and configuration.
   
   The runtime already has the core fields. #3724 supplied the pure-interface 
`rpc.service` behavior; merged #3743 added regression coverage, and #3744 added 
dynamic logger tests. The merged [samples 
#1128](https://github.com/apache/dubbo-go-samples/pull/1128) supplies a 
runnable telemetry stack. This task reuses these contributions and delivers the 
remaining Admin-facing contract evidence.
   
   I would like to take this bounded task as part of my OSPP work; requested 
assignee: @AsperforMias.
   
   ### Proposed solution (optional)
   
   Extend/reuse `dubbo-go-samples/observability/integration` and the existing 
trace-integration logger sample. Produce a compact fixture bundle with a 
README, runnable configuration, real `metrics.prom`, Provider/Consumer spans 
from the same RPC, and context/ordinary JSON log examples. Equivalent file 
names are fine. Use the Go Context Logger for correlation examples; distinguish 
it from the sample's manually extracted fields and the AccessLog filter.
   
   Acceptance criteria:
   
   - [ ] Pin the Go SDK and samples revisions plus collector/exporter 
configuration. A clean checkout can generate the bundle with documented 
commands.
   - [ ] Generate real successful and failed RPCs; show Provider and Consumer 
request/failed counters, QPS and RT names/units, and the actual configured 
scrape endpoints. Clearly separate cumulative counters from window metrics.
   - [ ] Cover non-empty group/version. Verify per process `service.name == 
application_name`, `rpc.service == interface` as the pure interface, 
`rpc.method == method`, and SERVER/provider versus CLIENT/consumer. Record 
existing group/version labels and optional trace attributes without adding a 
new mandatory `side` label or renaming spans.
   - [ ] Export both sides of one trace with matching trace ID and the correct 
parent relationship. Include emitted CtxLogger fields and an ordinary/untraced 
log with correlation fields absent; document the opt-in setting. Do not claim 
AccessLog correlation.
   - [ ] Include assertions or a small verifier for generated values and 
references to already merged regression tests; avoid duplicating #3743/#3744 
test implementations.
   - [ ] Describe Prometheus scrape/discovery and Admin datasource/dashboard 
prerequisites, link existing Admin metric acceptance evidence, and record 
remaining deployment limitations separately from successful fixture generation.
   - [ ] Put sample-specific commands beside the sample. Put stable general 
user guidance in `apache/dubbo-website`, following [the maintainer's 
guidance](https://github.com/apache/dubbo-go/pull/3745#issuecomment-5747041200).
 Keep revision-specific audit material in Discussion.
   
   Starting points: [RPC 
labels](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/metrics/rpc/util.go),
 [metric 
families](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/metrics/rpc/metric_set.go),
 [OTel 
filters](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/filter/otel/trace/filter.go),
 [resource 
configuration](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/instance_options_init.go),
 and 
[sample](https://github.com/apache/dubbo-go-samples/tree/main/observability/integration).
   
   Independence and existing ownership:
   
   - Start directly from current `develop`/samples main. This fixture delivery 
imports no router resources and needs no code from 
apache/dubbo-admin#1552–#1556 or either router verification issue.
   - Admin-side query adaptation is already tracked by 
apache/dubbo-admin#1590/#1591. SDK idle-window correctness is already tracked 
by #3764/#3765. Link their status; do not duplicate their implementations or 
gate publication of the field-contract bundle on their merge. Do not present 
fixture generation as full dashboard/idle-window acceptance.
   - Metrics semantics remain coordinated through #3337, tracing through 
#3338/#3551, and default activation through #3568. No shared error-taxonomy 
redesign, new metric family, Loki/Elasticsearch integration, or full dashboard 
redesign is requested.
   
   Related: #3562; apache/dubbo-admin#1524. This issue completes only the 
bounded Go-side handoff, not the entire observability EPIC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to