AsperforMias opened a new issue, #3769:
URL: https://github.com/apache/dubbo-go/issues/3769

   ### What problem would this solve?
   
   The tag-route portion of [OSPP 
262e80018](https://summer.ospp.ac.cn/org/prodetail/262e80018?list=org&navpage=org&lang=zh)
 requires Admin's existing application-level tag rule to be looked up, updated 
and applied correctly by Go. Existing Go tag tests cover matcher and cache 
behavior, but the Admin-produced payload, provider-application key and 
config-center delivery need a compact compatibility case under 
apache/dubbo-admin#1523.
   
   This task verifies and documents existing behavior. It does not presume that 
a new tag router or new routing semantics are required.
   
   I would like to take this bounded OSPP slice; requested assignee: 
@AsperforMias.
   
   ### Proposed solution (optional)
   
   Add source-backed fixtures and deterministic compatibility tests using the 
current Admin tag rule and Go's existing tag router/config-center facilities.
   
   Acceptance criteria:
   
   - [ ] Pin the Admin revision and record the actual tag YAML, config version, 
application scope/key, config-center namespace/group and data ID/ZooKeeper 
path. Verify Go subscribes to the matching provider-application `.tag-router` 
key, including when the consumer application has a different name.
   - [ ] Cover a rule loaded before first routing, subsequent update, explicit 
disabled rule and deletion. Verify replacement/removal affects the selected 
providers and does not leave the old dynamic rule active.
   - [ ] Cover Admin-produced address-based tags and the currently supported 
match fields. Demonstrate tagged requests, untagged requests and an unmatched 
tag; document fallback/force behavior using the fields actually emitted by 
Admin and the request.
   - [ ] Include at least two distinguishable provider instances and assert no 
unintended cross-tag selection. Check the existing cached and uncached routes 
agree where the fixture uses a cache-supported rule.
   - [ ] Preserve omitted versus explicit field defaults as defined by the 
existing Go/Admin rule contracts. Document unsupported/malformed cases rather 
than introducing a new policy model.
   - [ ] Supply local automated commands and a concise config-center/RPC 
validation recipe. Clearly distinguish mock/event coverage, optional 
external-service tests and an executed deployment acceptance.
   
   Starting points: [Go tag 
lookup/listener/parser](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/tag/router.go),
 
[matching](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/tag/match.go),
 [cache 
path](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/tag/cache.go),
 [existing 
tests](https://github.com/apache/dubbo-go/blob/5d892b0a7fd4fb5e6679112a18eccbf8a6eabab2/cluster/router/tag/router_test.go),
 and [Admin tag 
service](https://github.com/apache/dubbo-admin/blob/b9ee1b779fd7e87d0097edb5645e9c9176a917a7/pkg/console/service/tag_rule.go).
   
   Independence and boundaries:
   
   - Start from current Go `develop` and fixtures from already merged Admin 
`develop@b9ee1b7`. No code from 
apache/dubbo-admin#1552–apache/dubbo-admin#1556, new affinity/script resources, 
their codecs or their UI/history/rollback paths is required.
   - This issue can be delivered independently of the condition/instance-switch 
and telemetry fixture issues; no stacked implementation branches are needed.
   - Reuse the current application-level discovery/metadata model; do not 
restore interface-level discovery, redesign tag routing or take over script 
timeout #3566/#3575.
   
   Related: apache/dubbo-admin#1523. This is only the application tag-route 
compatibility slice of the OSPP task.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to