sharanggupta commented on code in PR #16527:
URL: https://github.com/apache/dubbo/pull/16527#discussion_r4327759948
##########
dubbo-common/src/test/java/org/apache/dubbo/common/utils/ParametersTest.java:
##########
@@ -16,28 +16,19 @@
*/
package org.apache.dubbo.common.utils;
-import java.util.HashMap;
import java.util.Map;
+import org.junit.jupiter.api.Test;
+
import static org.junit.jupiter.api.Assertions.assertEquals;
class ParametersTest {
final String ServiceName = "org.apache.dubbo.rpc.service.GenericService";
final String ServiceVersion = "1.0.15";
final String LoadBalance = "lcr";
- public void testMap2Parameters() {
Review Comment:
I removed it because it only reads back the values it puts into the
`HashMap` itself, but you're right, that's not for this PR to decide. It's back
in e021642, with `@Test` so that it runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]