SiriusTL666 commented on PR #16542:
URL: https://github.com/apache/dubbo/pull/16542#issuecomment-6399734599

   CI is green on the current head (`a519aa8`) — all 32 checks pass:
   
   - `Unit Test On ubuntu-22.04` for **Java 8, 11, 17, 21 and 25**
   - `Integration Test` and `Samples Test` (all 3 job groups) plus their Jacoco 
reports
   - `Build Dubbo`, `Check License`, `Check if code needs formatting`, 
`error-code-inspecting`
   
   The local run also passes: `mvn -pl dubbo-registry/dubbo-registry-multicast 
test` → 17/17.
   
   For context on why this is worth a fix rather than left alone: `clean()` 
calls `isExpired()` for **every** provider in the multicast group, from one 
scheduled thread (`DubboMulticastRegistryCleanTimer`), and each probe opens two 
connections 100ms apart. One unreachable provider therefore stalls expiry 
handling for every other provider. Reverting the timeout to `connect(address, 
0)` makes the new test take **42 seconds** and fail; with the bound it passes.
   
   If you would prefer this to be split (for example, a separate PR for the 
interrupt-flag handling), or want the timeout configurable per provider rather 
than per registry URL, I am happy to adjust.
   
   One thing I did not change, in case it matters for review: `SOL` and the 
other checks are outside this module, so I have not verified how the multicast 
registry behaves in a cluster with mixed reachability. The fix only bounds each 
individual probe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to