AsperforMias opened a new pull request, #1157:
URL: https://github.com/apache/dubbo-go-samples/pull/1157

   ## Summary
   
   Pin the SDK to `v3.3.3-0.20261027084029-a1aa788a3007`, the merge commit of 
[apache/dubbo-go#3770](https://github.com/apache/dubbo-go/pull/3770), and 
regenerate the observability capture. With that fix, consumer metric 
`application_name` identifies the client and matches OTel `service.name`, so 
the known mismatch recorded in #1155 is gone.
   
   Refs apache/dubbo-go#3767.
   
   ## Why a pseudo-version
   
   #3770 has been merged into dubbo-go `develop`, but no tag contains it yet: 
the latest tags are `v3.3.2` and `v3.3.2-20260910`, both cut before the merge. 
A tagged pin would therefore still produce the mismatched capture.
   
   The pin points at the #3770 merge commit itself rather than the current 
`develop` head, so the only runtime change pulled in beyond #3770 is what was 
already on `develop` before it. The one later commit (#3771, Nacos rule 
deletion callbacks) is not included. This follows the existing practice in this 
repository of pinning `develop` snapshots (the previous pin `e4aabaf27773` and 
#1147 are also pseudo-versions).
   
   Once a dubbo-go release containing #3770 is tagged, the pin can be switched 
to that tag.
   
   ## Dependency changes
   
   Only the `dubbo.apache.org/dubbo-go/v3` line was edited by hand. Every other 
change below is the result of `go mod tidy` with the new pin:
   
   | Module | Before | After |
   |---|---|---|
   | `dubbo.apache.org/dubbo-go/v3` | `v3.3.3-0.20260911014420-e4aabaf27773` | 
`v3.3.3-0.20261027084029-a1aa788a3007` |
   | `go.opentelemetry.io/otel` | v1.44.0 | v1.45.0 |
   | `go.opentelemetry.io/otel/sdk` | v1.44.0 | v1.45.0 |
   | `go.opentelemetry.io/otel/trace` | v1.44.0 | v1.45.0 |
   | `go.opentelemetry.io/otel/metric` (indirect) | v1.44.0 | v1.45.0 |
   | `go.opentelemetry.io/otel/exporters/otlp/otlptrace` (indirect) | v1.21.0 | 
v1.45.0 |
   | `go.opentelemetry.io/proto/otlp` | v1.0.0 | v1.11.0 |
   | `github.com/grpc-ecosystem/grpc-gateway/v2` (indirect) | v2.16.0 | v2.29.0 
|
   | `github.com/go-logr/logr` (indirect) | v1.4.3 | v1.4.4 |
   | `google.golang.org/genproto/googleapis/api` (indirect) | 
`v0.0.0-20260526163538-3dc84a4a5aaa` | `v0.0.0-20260720211330-0afa2a65878a` |
   | `google.golang.org/genproto/googleapis/rpc` (indirect) | 
`v0.0.0-20260622175928-b703f567277d` | `v0.0.0-20260720211330-0afa2a65878a` |
   
   `otlptrace/otlptracegrpc`, `otlptrace/otlptracehttp`, `stdouttrace` and 
`zipkin` stay at v1.21.0 because nothing in the new module graph requires a 
newer version; the build and the observability integration test pass with this 
combination.
   
   ## Changes
   
   - `go.mod` / `go.sum`: new SDK pin plus the tidy result above.
   - `observability/integration/capture`: regenerated `consumer.prom`, 
`provider.prom`, `traces.jsonl` and `manifest.json`. Consumer 
`application_name` is now `dubbo-observability-client`. The trace capture also 
contains a provider `Watch` span exported by the new SDK; validation does not 
depend on it.
   - `capture/README.md`: remove the known-mismatch note.
   - `test_validate.py`: the checked-in capture is now expected to pass the 
strict check. The negative case that corrupts `application_name` and expects a 
mismatch is kept.
   
   ## Validation
   
   - `capture.py` live capture: no field mismatches.
   - `test_validate.py`: 9/9 pass.
   - `./integrate_test.sh observability/integration` passes with Go 1.25.0 
(Prometheus, Jaeger and Grafana checks).
   - License headers present on the `.prom` captures; `.licenserc.yaml` 
unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to