Qiao-yq commented on PR #1610:
URL: https://github.com/apache/dubbo-admin/pull/1610#issuecomment-6498507105

   Updated head to `5e5cc5c` addressing the review feedback.
   
   **Dependency sync** — merged the latest #1609 (`8266dfd`, 10 commits) in 
`35116df`. The only conflict was `ai/store/gorm/store_test.go`; both the 
compilation-contract test and the new retry/replay tests were kept. `go test 
./...` passes locally in `ai/`.
   
   **Session owner vs. acting subject (P2, larry-zy)** — fixed in `923916a`:
   - `CollectRequest` now carries the canonical `SessionTenantID` / 
`SessionOwnerID` from the trusted Session/Turn snapshot.
   - Item and tool-batch provenance are validated against that owner, and the 
caller is checked with `AccessContext.CanAccessOwner` — same-tenant 
`ai:sessions:admin` is allowed, cross-tenant stays denied.
   - Canonical tool batches are recorded with the Session owner instead of the 
acting subject (`react/tool_records.go`).
   - Regressions added in `c79e671` and `923916a`: administrator context 
compilation, ledger/snapshot/recovery access, canonical tool execution through 
the full ReAct path, and administrator-owned/mismatched batch rejection. 
Ordinary-owner and unauthorized-caller paths are covered alongside.
   
   **JSON fail-open (P2, AlexStocks)** — `JSON()` is now fail-closed (panics on 
marshal error) in `923916a`, with `TestJSONFailsClosedOnMarshalError`.
   
   **P3 follow-ups** — in `923916a` / `5e5cc5c`:
   - invalid budget configuration (output reserve plus safety margin exceeding 
the context window) now returns `ErrInvalidBudget` instead of 
`ErrMandatoryBudget`;
   - tool call inputs are bounded with the same `limitValue` limits as outputs;
   - `limitValue` returns the original container when nothing was truncated;
   - `CompilationReport.InputTokens` is documented as a UTF-8 JSON byte upper 
bound, not provider-reported usage.
   
   Re-review welcome.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to