AlexStocks commented on code in PR #1:
URL: https://github.com/apache/dubbo-net/pull/1#discussion_r4430904272


##########
.github/workflows/license.yml:
##########
@@ -0,0 +1,30 @@
+name: License header check
+
+# Checks source headers only; passing does not establish SGA/ICLA filing or IP
+# clearance. The project owner confirmed the contributed source authorship.
+on:
+  push:
+    branches: [main, codex/import-dubbonet-history]

Review Comment:
   🟡 **同一处问题:个人分支名进了 ASF 官方工作流**
   
   和 `build.yml:5` 是同一个问题,这里单独挂一条方便分别 resolve:`codex/import-dubbonet-history` 
是本次导入用的个人工作分支,合并进 main 之后它在官方仓库里没有任何意义,却会让每次向同名分支 push 都触发一次 header 全量扫描。
   
   **Suggestion**:与 `build.yml` 一起改成只保留 `main`:
   
   ```yaml
   on:
     push:
       branches: [main]
     pull_request:
       branches: [main]
     workflow_dispatch:
   ```
   
   另外这条 workflow 现在已经是 `comment: never`(`.licenserc.yaml` 里)且 `token: 
''`,也就是说它只会在 check 列表里给一个红/绿,不会在 PR 里留言。这是合理的取舍(避免 bot 噪音),但建议在 workflow 
顶部注释里写一句「失败时看 Actions 日志里的具体文件」,否则第一次踩到的人不知道去哪找缺 header 的文件。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to