SilentNul commented on issue #3785: URL: https://github.com/apache/dubbo-go/issues/3785#issuecomment-6556392348
Tested `go.yaml.in/yaml/[email protected]` against dubbo-go `main` (`555a9ba`), Go 1.25.12 / windows-amd64. **Main module: OK.** The module graph is unchanged — rc.7's `go.mod` file is byte-identical to rc.6's (same `h1:` for the mod file), and there is no `replace` directive — so the bump is just `go.mod` 1 line + `go.sum` 2 lines. The YAML-consuming packages are all green on rc.7: ``` ok cluster/router/condition 1.340s ok cluster/router/tag 0.783s ok cluster/router/affinity 0.719s ok config_center/parser 2.944s ok protocol/rest/config/reader 0.785s ok protocol/triple/openapi 3.383s ok protocol/triple/internal/http3config 2.126s ``` `go build ./...` passes for the whole module and `go vet` is clean on `config_center/parser` + `cluster/router/condition`. To be precise about scope: the **full** test suite was not run here — several packages need docker fixtures (zookeeper / nacos / etcd), so CI has to cover those. No behavioural change was observed in the config parsing paths that did run (YAML config → `config_center/parser`, router rule parsing, REST/gRPC config readers). **One blocker, in a separate module of this repo:** `tools/protoc-gen-triple-openapi` fails to build on rc.7: ``` github.com/pb33f/[email protected]/datamodel/high/v3/document.go:178:13: yamlDumper.SetIndent undefined (type *yaml.Dumper has no field or method SetIndent) ``` Root cause is rc.7 itself, not libopenapi. In rc.6 `Dumper` was an exported alias (`type Dumper = libyaml.Dumper`, `yaml.go:555`), so it carried `SetIndent` / `SetCompactSeqIndent`; in rc.7 it became a wrapper struct forwarding only `Dump` / `Close` (`yaml.go:855-884`). `libopenapi` calls `NewDumper(...).SetIndent(indent)` in `(*Document).RenderWithIndention`. Bisected locally: the same submodule builds on rc.6 and fails on rc.7. So that submodule is intentionally left on rc.6 for now; the main module bump is in #3786. I've reported the `Dumper` change upstream with a reproducer (yaml/go-yaml#469). Happy to re-test once rc.8 / v4.0.0 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
