Similarityoung opened a new issue, #184:
URL: https://github.com/apache/dubbo-go-pixiu-samples/issues/184

   ### Problem
   
   CI has no repository-wide unit-test job and does not execute all test files. 
The only test job runs a manually maintained sample list from 
`start_integrate_test.sh`, so a passing run does not make it clear which tests 
executed or why the remaining tests were excluded.
   
   Most integration tests are not separated by build tags. Running `go test 
./...` directly is therefore unsafe because many tests require Docker, Pixiu, 
backend services, fixed ports, or other external state. There is also no shared 
root test entrypoint, so local and CI commands can diverge and new tests can be 
silently omitted.
   
   ### Proposal
   
   - Add root `Makefile` targets such as `test-unit`, `test-integration`, and 
`test`.
   - Classify tests as unit or integration, preferably using `//go:build 
integration`.
   - Run unit tests in a dedicated CI job without Pixiu or Docker dependencies.
   - Keep the curated integration runner as the integration-test entrypoint.
   - Add a check that fails when a `_test.go` file is covered by neither test 
category.
   
   ### Acceptance criteria
   
   - `make test-unit` and `make test-integration` execute the complete, 
explicitly defined suites.
   - CI uses these shared entrypoints.
   - A new unclassified test causes CI to fail.
   - CI logs clearly identify which test categories were executed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to