NeverENG opened a new pull request, #21: URL: https://github.com/apache/dubbo-net/pull/21
### Description Refs #17 (part 2 of the protocol-constants work; **do not close the Issue**, response kinds remain for a later PR). Follows #16. - Put Dubbo2 magic bytes, header layout/field offsets and widths, flags/mask, serialization ID, and OK status in `DubboService/Native/Protocol/DubboFrameConstants.cs`. - Use these definitions for encoding, decoding and the connection receive loop. Keep the existing `NativeDubboCodec` internal aliases used by the current callers/tests; safety/capacity limits stay local to the codec. - Preserve the encoded bytes, validation behavior, error text, and public API; do not change Hessian2 or response-kind handling. ### Test-first evidence 1. `98b6e46`: add tests with **raw, independent expected bytes** for heartbeat request/response (including serialization mask), decoded flags/fields and invalid magic; run them against the unchanged implementation (5 passed). 2. `31a17fb`: implement the constants extraction. ### Verification - [x] Targeted frame/codec/connection tests: 21 passed. - [x] Unit test project: 410 passed, 0 failed. - [x] Release build: successful (3 pre-existing warnings). - [x] `dotnet format DubboNet.sln --verify-no-changes --include <changed files> --no-restore`. - [x] Target branch `main`. ### Follow-up Response kind `0–5` is a separate PR under #17. Client/registry string contracts are tracked separately under #20. Leave this PR as Draft for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
