lulianqi opened a new pull request, #23:
URL: https://github.com/apache/dubbo-net/pull/23

   ### Description
   
   Fixes #14
   
   Ports the validated end-to-end environment from [lulianqi/DubboNet at 
dd536c4](https://github.com/lulianqi/DubboNet/commit/dd536c43aa5b50b14bb584c30b2606c0136064d4)
 onto current Apache `main`, without reverting the .NET 10 target or the 
subsequent runtime/security fixes.
   
   ### What is included
   
   - Preserve the environment directory **`Tests/EndToEndTestEnvironment`**, 
including the complete **`JavaProviders`** Maven reactor, service 
interfaces/models/implementations, and all four version-specific Provider 
projects.
   - Preserve the new independent **`Tests/DubboNetEndToEndTests`** xUnit 
project, add it to the solution, and target `net10.0`.
   - Add a separate **End-to-end tests** workflow. Its `on` block is exactly 
the same as **Build and test**: pushes to `main`, pull requests targeting 
`main`, and manual dispatch. **No path filters.**
   - Build temporary ZooKeeper 3.8.4 / Nacos 2.5.4 containers and build/run 
Java Providers from source as test-host processes. No personal server, private 
JAR, registry credentials, or new client runtime dependencies.
   - Run both existing executables in **both ZooKeeper and Nacos modes**, 
including Native TCP/Hessian2 and Triple HTTP/JSON direct calls.
   - Make QueryDemo assert actual fixture values for all ten QueryAsync 
overloads and both direct transports, with a non-zero exit code for 
invocation/deserialization/value failures; add offline regression tests for its 
verifier.
   - Verify the expected Provider exception identity/message instead of 
counting arbitrary failures as expected business exceptions. Dubbo generic 
wrappers do not guarantee custom exception fields such as `errorCode`.
   - Add `run-local.sh`, bounded/fail-fast readiness, PID-aware Provider 
cleanup, Compose cleanup, client/Provider/registry logs, and separate TRX 
artifacts.
   - Pin Action revisions, use read-only repository permissions, and do not 
retain checkout credentials. Registry ports bind to loopback; Java fixture 
ports are for trusted disposable test hosts only.
   - Add ASF headers to new source/configuration files and document coverage, 
lifecycle, diagnostics, and extension points in both READMEs plus the 
environment guide.
   
   ### Coverage
   
   | Registry | Provider versions |
   | --- | --- |
   | ZooKeeper | 2.7.23, 3.1.11, 3.2.20, 3.3.6 |
   | Nacos Naming / Config | 3.2.20, 3.3.6 |
   
   The new xUnit suite covers **150 method-invocation cases** (25 signatures 
across six combinations) plus **six metadata coverage checks**. It retains 
generic-type erasure when comparing metadata signatures. Network cases require 
explicit `DUBBONET_E2E_ENABLED=true`; once enabled, missing configuration or 
unavailable services fail rather than skip.
   
   ### Validation
   
   - Local Release solution build passed.
   - **418 offline unit tests passed**, with no skips.
   - Explicitly disabled network suite skips its two theories as intended.
   - License headers: **133 valid, 0 invalid**.
   - `actionlint`, Bash syntax checks, trigger-equivalence checks, relative 
documentation links, script failure/cleanup smoke checks, and `git diff 
--check` passed.
   - `dotnet format --verify-no-changes` passed for added/modified C# files.
   - Local-only NuGet packing passed; no Java source/JARs, Maven files, or test 
projects enter the package. No package/image was published.
   - No changes to client runtime source, `DubboNet.csproj`, LICENSE, NOTICE, 
or the existing fast build/unit workflow.
   
   The machine used for local checks has no Docker. The actual migrated branch 
was therefore exercised by manual dispatch in the author's original repository, 
using the exact same commit/workflow intended for this PR; see the validation 
run below. This does not replace the Apache-hosted PR checks.
   
   ### Checklist
   
   - [x] The target branch is `main`.
   - [x] The commits are signed off and this PR links the corresponding issue.
   - [x] Relevant C# formatting was checked.
   - [x] Local tests passed and real end-to-end validation was executed.
   - [x] New tests and matching English/Chinese documentation are included.
   
   ### Migrated-branch validation run
   
   **Passed**: [End-to-end tests — run 
41683914030](https://github.com/lulianqi/DubboNet/actions/runs/41683914030), 
commit `718c3fd` (the PR head). All real test steps, log uploads, and final 
cleanup completed successfully. Existing compiler/analyzer warnings remain 
unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to