bosprimigenious opened a new pull request, #1080:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1080

   **What this PR does**:
   
   Preserve nil-valued generic Dubbo map entries as JSON `null` instead of 
silently dropping them. Apply the existing `class` metadata filter first, so 
`class:nil` remains hidden. The production change is 4 added / 3 removed lines; 
two files, no dependency changes.
   
   **Which issue(s) this PR fixes**:
   
   Fixes #1079
   
   **Special notes for your reviewer**:
   
   - Root pristine regressions: **9 failed / 6 passed**; patched: **15 
passed**, including a real Hessian encode/decode case.
   - Root relevant `go test ./pkg/common/util/... ./pkg/common/http 
./pkg/filter/http/remote -gcflags=-l -race -count=1`: **78 passing test 
events** (includes parent groups), zero skipped tests. Three packages tested; 
`stringutil` reports no test files and is not a test pass. Scoped vet passes.
   - Root independently reran a 28-leaf response matrix: pristine 14 failures / 
14 passes, patched 28 passes. Four real Hessian→HCM `handleHTTPRequest`→local 
`httptest` response paths now return 200/JSON with nulls intact. No live 
provider RPC is claimed.
   - Root imports-formatter 1.0.10 on copies leaves both files byte-identical; 
gofmt/diff checks pass; original ASF headers and go.mod/go.sum are retained.
   
   **Draft / full acceptance NOT READY:** full `./...` race, golangci, complete 
license CI, samples/Docker/RISC-V gates have not been established locally. 
Await the applicable CI at this exact head. Typed nil maps/slices retain 
existing behavior; unrelated byte/typed-map conversions and marshal-error 
handling are outside this patch. Initial local root test commands named a 
nonexistent/empty remote package; these setup failures were corrected to the 
actual HTTP remote-filter path before the reported passing run.
   
   **Does this PR introduce a user-facing change?**:
   
   ```release-note
   Generic Dubbo map responses retain ordinary null-valued fields as JSON null, 
matching the existing string-keyed map behavior. Class metadata remains 
excluded.
   ```
   
   AI disclosure: OpenAI Codex generated this patch, tests, text and automated 
verification. No human review is claimed. The commit includes Signed-off-by and 
Generated-by attribution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to