CAICAIIs commented on PR #1054: URL: https://github.com/apache/dubbo-go-pixiu/pull/1054#issuecomment-6718327569
The end-to-end sample requested in review is up: apache/dubbo-go-pixiu-samples#186. It adds `dubbogo/simple/generic`: a non-IDL Triple provider on `tri://127.0.0.1:20001` with no registry, and two routes here that use this PR's `generic` field: - `/api/v1/generic/map` with `generic: "true"` — typed argument list in, `"Hello pixiu"` out; - `/api/v1/generic/gson` with `generic: gson` — JSON text in and out, with the response written verbatim (the test would catch a second encoding). Locally, `./integrate_test.sh dubbogo/simple/generic` passes both cases against this branch: ``` === RUN TestMapMode --- PASS: TestMapMode (0.03s) === RUN TestGsonMode --- PASS: TestGsonMode (0.00s) ok github.com/dubbo-go-pixiu/samples/dubbogo/simple/generic/test 0.588s ``` The sample is its own Go module because gson mode needs the pointer fix from dubbo-go `v3.3.2-20260910`; the samples root module still pins `v3.3.2-20260419`, and the samples#186 description explains why a repository-wide bump is not possible today. The samples PR is a draft on purpose: its integration job needs `integrationRequest.generic` from this PR, so it turns green once this one is merged and pixiu `develop` has the field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
