AlexStocks commented on code in PR #34:
URL: https://github.com/apache/dubbo-net/pull/34#discussion_r4513578582


##########
Docs/en/architecture/registry.md:
##########
@@ -0,0 +1,19 @@
+# Registry and Discovery: Addresses, Notifications, References
+
+[Call-path overview](index.md) · [中文](../../zh/architecture/registry.md)
+
+## Current entries and handoffs
+
+| Entry | What it passes downstream |
+| --- | --- |
+| 
[`ProviderDiscovery.GetProviderEndPointsAsync`](../../../Registry/ProviderDiscovery.cs)
 | Both requests and metadata lookup can discover a service here; discovery 
coalesces in-flight tasks per service and path mode. The endpoints are not a 
second callable-Provider snapshot. |

Review Comment:
   [P2] 「看代码」表里的 5 个 `Registry/*.cs` 链接在 head 上指向不存在的路径
   
   触发条件:在 head `e2de98f` 上打开本 PR 新增的 `Docs/en/architecture/registry.md`(中文同构文件 
`Docs/zh/architecture/registry.md` 第 9、10、19 行),点击表格里 
`ProviderDiscovery.GetProviderEndPointsAsync`、`ProviderDiscovery.DiscoverAsync`、以及第
 19 行 `Read:` 段的 ZooKeeper / Nacos / 共享连接存储三个链接。
   
   实际影响:这一页是「注册与发现」唯一的源码入口,5 个链接全部落到 404。第 19 行那三个封装类链接是读者从文档下钻到 
ZooKeeper/Nacos 实现的唯一通路,断掉之后该页只剩文档间的互链,PR 描述的「按语言组织并从文档直达源码」在这页不成立。
   
   证据(均针对 head `e2de98f`,非旧 revision):
   - `git/trees/e2de98f?recursive=1` 返回 294 个条目、`truncated=false`;顶层只有 
`.github/`、`Clients/`、`Configuration/`、`Docs/`、`DubboService/`、`MyCommonHelper/`、`NetService/`、`Resource/`、`Tests/`
 等,**没有 `Registry/` 目录**,也没有 `Metadata/` 目录。
   - 全树按名字检索 `ProviderDiscovery` 命中 0 —— 该文件在当前 head 
下不存在(可能已改名或并入其他类型),所以这两个表格行不仅是路径前缀错,目标文件名也需要重新确认。
   - `MyZookeeper.cs`、`MyNacos.cs`、`MultiMyZookeeperStorage.cs` 的实际位置是 
`Clients/RegistryClient/`。
   
   修复方向:`../../../Registry/MyZookeeper.cs` → 
`../../../Clients/RegistryClient/MyZookeeper.cs`(Nacos、共享连接存储同理);`ProviderDiscovery`
 两处先按当前代码定位真实承载类型再改链,找不到对应类型就把单元格退回纯文本,避免留死链。同一前缀模式在 
`Docs/{en,zh}/architecture/index.md` 与 `metadata.md` 里还有多处,建议一次性全量扫一遍再提交,en/zh 
两份同步。
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to