Aias00 commented on code in PR #992:
URL: https://github.com/apache/dubbo-go-pixiu/pull/992#discussion_r4522216675


##########
admin/controller/auth/auth_test.go:
##########
@@ -47,12 +47,8 @@ func testJWT(t *testing.T) *JWT {
 }
 
 func TestParseTokenRejectsUnexpectedSigningMethod(t *testing.T) {
-       claims := CustomClaims{
-               Username: "admin",
-               StandardClaims: jwt.StandardClaims{
-                       ExpiresAt: time.Now().Add(time.Hour).Unix(),
-               },
-       }
+       claims := CustomClaims{Username: "admin"}

Review Comment:
   Done in `3f53c83e`. The auth fixture file now exactly matches #1062 
(`2c65c6c2`), so there is one shared implementation instead of two conflicting 
fixes. It remains here only to keep lint passing until the shared fix reaches 
develop; after #1062 merges, this file drops out of this PR’s diff. Both merge 
orders are conflict-free and produce the same tree. Auth/MQ race tests and 
golangci-lint v2.4.0 pass. The PR description is updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to