Aias00 commented on code in PR #3436:
URL: https://github.com/apache/dubbo-go/pull/3436#discussion_r4522530925


##########
cluster/cluster/forking/cluster_invoker.go:
##########
@@ -72,16 +72,25 @@ func (invoker *forkingClusterInvoker) Invoke(ctx 
context.Context, invocation pro
        }
 
        resultQ := queue.New(1)
+       forkCtx, cancel := context.WithCancel(ctx)
+       defer cancel() // cancel forkCtx when Invoke returns, signaling all 
forked goroutines to stop

Review Comment:
   Synced current develop in `f6eb81ae`, resolving the forking and go.mod 
conflicts while preserving #3790’s duration parsing, per-call timeout 
overrides, and provider URL settings. The leak regression uses `1s`/`50ms` and 
retains goleak checks for first-result and timeout cancellation. Forking race 
tests, 30 repeated regression runs, all cluster tests, vet, and golangci-lint 
v2.7.2 pass. Upstream dependency versions are preserved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to