github-advanced-security[bot] commented on code in PR #1085:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1085#discussion_r4527681417


##########
.github/workflows/github-actions.yml:
##########
@@ -113,6 +113,34 @@
           files: ./coverage.txt
           flags: unittests
 
+  admin-build:
+    name: Admin Build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
+        with:
+          go-version-file: 'go.mod'
+          cache: true
+
+      - name: Download Go modules
+        run: sh .github/scripts/download-go-modules.sh
+
+      - name: Build Admin backend
+        run: go build -o /tmp/pixiu-admin ./cmd/admin
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+          cache-dependency-path: admin/web/package-lock.json
+
+      - name: Build Admin frontend
+        working-directory: admin/web
+        run: |
+          npm ci

Review Comment:
   ## SonarCloud / JavaScript package manager scripts should not be executed 
during installation
   
   <!--SONAR_ISSUE_KEY:AaHGVM4sTumv2y5KJVNN-->Omitting "--ignore-scripts" 
allows lifecycle scripts to run during package installation. <p>See more on <a 
href="https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&issues=AaHGVM4sTumv2y5KJVNN&open=AaHGVM4sTumv2y5KJVNN&pullRequest=1085";>SonarQube
 Cloud</a></p>
   
   [Show more 
details](https://github.com/apache/dubbo-go-pixiu/security/code-scanning/271)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] Add Pixi... XnLemon (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... github-advanced-security[bot] (via GitHub) via notifications
    • Re: [PR]... Alanxtl (via GitHub) via notifications
    • Re: [PR]... codecov-commenter (via GitHub) via notifications
    • Re: [PR]... github-advanced-security[bot] (via GitHub) via notifications
    • Re: [PR]... XnLemon (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications
    • Re: [PR]... AlexStocks (via GitHub) via notifications
    • Re: [PR]... sonarqubecloud[bot] (via GitHub) via notifications

Reply via email to