Similarityoung commented on code in PR #1085: URL: https://github.com/apache/dubbo-go-pixiu/pull/1085#discussion_r4561339344
########## .github/workflows/admin-build.yml: ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +name: Admin CI + +permissions: + contents: read + +on: + push: + paths: + - 'admin/**' + - 'cmd/admin/**' + - 'go.mod' + - 'go.sum' + - '.github/workflows/admin-build.yml' + pull_request: + paths: + - 'admin/**' + - 'cmd/admin/**' + - 'go.mod' + - 'go.sum' + - '.github/workflows/admin-build.yml' Review Comment: This workflow is not triggered when only `docker-compose.yml` changes, and the job only builds Go/npm directly; no step validates Compose. As a result, the Node image change in this PR is not protected against regression — for example, switching back to an unsupported Node version would still leave Admin CI green. Since #842 asks for an admin build based on Compose, please add `docker-compose.yml` to both `push.paths` and `pull_request.paths`, and run at least `docker compose config --quiet`; ideally add a Compose-based smoke test. ########## docker-compose.yml: ########## @@ -114,7 +114,7 @@ services: # frontend(Web) frontend: - image: node:18.20.8 + image: node:22 Review Comment: This replaces the pinned `node:18.20.8` image with the moving `node:22` tag. The current 22.x release works with Vite, but the effective version can change between pulls and drift from CI. Prefer a concrete 22.x patch version, or a shared `.nvmrc` consumed via `node-version-file` in the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
