NeverENG commented on code in PR #43:
URL: https://github.com/apache/dubbo-net/pull/43#discussion_r4576862719
##########
DubboService/Native/NativeDubboCodec.cs:
##########
@@ -38,8 +38,12 @@ namespace DubboNet.DubboService.Native
internal static class NativeDubboCodec
{
internal const int DefaultMaxPayloadLength = 8 * 1024 * 1024;
- internal const int MaxNormalizedNodes = 100_000;
- internal const long MaxNormalizedJsonBytes = 32L * 1024 * 1024;
+ internal const int MaxNormalizedNodes = 2_000_000;
+ internal const int BaseNormalizedNodes = 100_000;
+ internal const int NormalizedNodesPerPayloadByte = 2;
+ internal const long MaxNormalizedJsonBytes = 64L * 1024 * 1024;
Review Comment:
Could we validate the new absolute budgets closer to their worst-case
behavior? The exact 2,000,000-node cutoff already has a unit test, but the
tests do not appear to cover expanded JSON near the new 64 MiB ceiling
(accepted just below, rejected just above, ideally using shared references).
Since the byte budget is not a managed-heap limit, could you also include a
reproducible peak-memory measurement for a near-2M-node response and several
concurrent responses? That would help justify these caps without making CI
depend on a flaky memory assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]