XnLemon opened a new pull request, #1092:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1092

   **What this PR does**:
   
   Keeps the xDS configuration watcher within the `StartxDsServer` lifecycle. 
On shutdown, it cancels the watcher and waits for it to finish before 
returning, so the etcd client remains available until any in-flight snapshot 
build completes.
   
   **Which issue(s) this PR fixes**:
   
   N/A
   
   **Special notes for your reviewer**:
   
   The race detector reported concurrent access to `adminconfig.Client` during 
`TestAdminSignalShutdown/SIGTERM`: `LogicResourceLoader.LoadClusters` read it 
while `CloseEtcdClient` cleared it. The xDS configuration watcher was not 
joined during shutdown.
   
   Related test: `cmd/admin TestAdminSignalShutdown/SIGTERM`.
   
   Validation: `git diff --check` and `gofmt -d admin/core/xds.go` passed. Go 
tests were not run.
   
   **Does this PR introduce a user-facing change?**:
   
   No.
   
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to