huynhhongan2005 commented on PR #3827:
URL: https://github.com/apache/dubbo-go/pull/3827#issuecomment-6910205626

   Hi @Alanxtl, thanks for the thorough review! I've pushed an update 
addressing all three points:
   - Serialized `Register`, `RegisterService`, and `unregisterService` with 
`serviceLifecycleMu` to prevent registration/unregistration interleaving, 
same-address backend deletion, and `MetadataInfo.Revision` write/write data 
races.
   - Added 
`TestServiceDiscoveryRegistry_ConcurrentRegisterAndUnregisterSameAddress` and 
tightened post-condition assertions in 
`TestServiceDiscoveryRegistryUnRegister_Concurrent` (verified 100/100 runs 
under `go test -race`).
   
   Ready for another look whenever you have a moment!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to