AsperforMias opened a new pull request, #3833:
URL: https://github.com/apache/dubbo-go/pull/3833

   ### Description
   
   Addresses the traditional Dubbo provider lifecycle in 
https://github.com/apache/dubbo-go/issues/3595; this does not close the issue.
   
   Derive provider request contexts from a cancelable getty session context, 
and preserve that parent when rebuilding the Dubbo invocation context. Cancel 
requests when their session closes or the server stops. A positive timeout 
attachment bounds the request; returning from the handler releases its context 
without closing the shared connection. Requests dispatched after session 
cleanup receive an already-canceled parent.
   
   Keep attachment propagation and tracing extraction. This does not change 
AttachmentKey or the default timeout sent over the wire. Traditional Dubbo has 
no per-request cancel frame: canceling the caller while keeping the connection 
open does not signal cancellation to the remote provider. Work retaining the 
request context after the handler returns will observe cancellation.
   
   Validation: targeted tests, targeted race tests, vet, lint, and getty 
package tests passed. Touched files are gofmt-clean. The Dubbo package suite 
still encounters the existing `TestDubboProtocol_Refer` isolation failure, 
reproduced on the unmodified baseline; the test passes alone. 
`TestDubboProtocolReferNoConnect` also failed on both trees because its fixed 
local port was occupied. Validation used mocks, not a new real-TCP integration 
test. The module-wide Make targets were not run.
   
   ### Checklist
   
   - [x] I confirm the target branch is `develop`
   - [ ] I have run `make fmt` to format my code
   - [ ] I have run `make test` to run local tests
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to