chaoyoung commented on PR #16585: URL: https://github.com/apache/dubbo/pull/16585#issuecomment-6945900119
Following the design feedback in https://github.com/apache/dubbo/pull/16585#pullrequestreview-5934267057, c698bf42e2 adopts the per-input state approach. The registry remains necessary for silent discard, while the shared lifecycle lock and in-flight counter are gone. Class javadoc now explains QUEUED / DELIVERING / HANDED_OFF / CLOSED ownership and registration racing with the terminal drain. Terminal cleanup claims only QUEUED inputs. Each started callback closes its own still-DELIVERING input in finally. Handoff removes transport ownership before invoking the listener; decoder-owned buffered inputs and original-message close-once behavior are preserved. A handoff that already passed its terminal check retains the existing decoder lifecycle; this update does not claim to fix every decoder-specific termination race. Before the refactor, the expanded 23-test fixture had exactly two failures: queued DATA was not released promptly on close/cancel while another callback was preparing. Afterward all 23 pass, including the original buffered-input/read-in-progress and post-handoff controls, plus registration-versus-close, preparation failure and error-handler failure. Full Triple package: 491 tests, 0 failures/errors, 2 existing disabled methods. Real Netty/Tomcat WebSocket clients pass 16 tests each on JDK 21 and 25 with the same disclosed no-registry/sample-bootstrap setup. Formatting, whitespace checks and independent review passed before pushing. The PR body now describes the final design and test scope. Local coverage covers the added generic-listener executable lines; one default base-hook forwarding line and two partial short-circuit conditions remain disclosed rather than claiming 100% branch coverage. New-head CI will be checked separately. Please review this update when available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
