do you feel that refactoring by extracting to a method may increase the
readability of code
```
/**
* If the provider service is detected offline,
* the client should not attempt to connect again.
*
* issue:
https://github.com/apache/incubator-dubbo/issues/3158
*/
if(cancelFutureIfClientIsOffline(reconnectExecutorFuture)) {
reconnectExecutorFuture.cancel(true);
}
private boolean cancelFutureIfClientIsOffline(ScheduledFuture future) {
return isClosed()) ? (future != null && !future.isCancelled()) :false;
}
```
[ Full content available at:
https://github.com/apache/incubator-dubbo/pull/3159 ]
This message was relayed via gitbox.apache.org for
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]