Order wise I think we should place this `if(urls == null)` before `if ((urls == null || urls.isEmpty())` , it will have more harmony in login layouting. Then you can replace the code `if ((urls == null || urls.isEmpty()) && !Constants.ANY_VALUE.equals(url.getServiceInterface()))` with `if (urls.isEmpty() && !Constants.ANY_VALUE.equals(url.getServiceInterface()))`
Do you feel it will make logic bit clearer? [ Full content available at: https://github.com/apache/incubator-dubbo/pull/3156 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
