I think putting both the null check together make it defficult to trace for which this exception has been raised.
I think we should refactor this to ``` Assert.notNull(channel,"Channel can't be null'); Assert.notNull(tick,"Tick can't be null"); ``` Assert is under package of org.apache.dubbo.common.utils. They way it works is, if the given first argument is null then it throws IllegalArgumentException with messaged getting passed here as second argument. What do you say? [ Full content available at: https://github.com/apache/incubator-dubbo/pull/3213 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
