shalk commented on a change in pull request #95: [dubbo-samples-async] remove
useless module; fix async module make it runnable
URL: https://github.com/apache/dubbo-samples/pull/95#discussion_r296159200
##########
File path: dubbo-samples-async/dubbo-samples-async-generated-future/pom.xml
##########
@@ -203,16 +203,17 @@
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-configcenter-zookeeper</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-common</artifactId>
+ </exclusion>
+ </exclusions>
Review comment:
avoid
https://github.com/apache/dubbo-spring-boot-project/issues/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
