There is another bug in here
in`DubboProtocol#createServer()`
the code `url = url.addParameter(Constants.CODEC_KEY, DubboCodec.NAME);` should
be
```
if (Objects.isNull(url.getParameter(Constants.CODEC_KEY)) {
url = url.addParameter(Constants.CODEC_KEY, DubboCodec.NAME);
}
```
Another way is at the `AbstractEndpoint#getChannelCodec`
have priority
`String codecName = url.getParameter("default.codec", "telnet");`
than
`String codecName = url.getParameter(Constants.CODEC_KEY, "telnet");`
But it is so dirty here.
And `ProtocolConfig#setCodec()` did not check Codec2 extension priority.
It should be check Codec2 extension first.if not exists, then check Codec
extension.
[ Full content available at: https://github.com/apache/dubbo/issues/4628 ]
This message was relayed via gitbox.apache.org for
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
