Hi guys, how are you? I found a refactoring opportunity on Dubbo and would like to share with you.
The completeCompoundConfigs () method is almost duplicated in the ReferenceConfigBase and ServiceConfigBase classes. As most of the attributes used by this method belong to the AbstractInterfaceConfig class, my suggestion is pull up the completeCompoundConfigs () method to the AbstractInterfaceConfig class. The benefits are duplicate code removal and the removal of a feature envy (this method has many calls to the super class). What do you think? [ Full content available at: https://github.com/apache/dubbo/pull/5506 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
