> > > @tswstarplanet > > > Hello, your unit test failed. > > > [ERROR] Failures: > > > [ERROR] ReferenceConfigTest.testReferenceRetry:115 expected: false but > > > was: true > > > > > > Yes, I debugged on my computer. I found it is because of the cache file. So > > I add a piece of code to the unit test method to delete the cache file. It > > works well on my computer. I don't know why it is not ok on github. > > I pulled your code to my local machine, and after running the unit tests, it > is consistent with the github answer. > > Maybe you forgot to modify > https://github.com/tswstarplanet/dubbo/blob/509d0ae44d944d4bbaa92b018a354673f239e9ee/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ReferenceConfigTest.java#L115 > > https://github.com/tswstarplanet/dubbo/blob/509d0ae44d944d4bbaa92b018a354673f239e9ee/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ReferenceConfigTest.java#L116 > > ```java > Assertions.assertTrue(success); > Assertions.assertNotNull(demoService); > ```
No, we should not modify the code like that just to pass the assertion. [ Full content available at: https://github.com/apache/dubbo/pull/5589 ] This message was relayed via gitbox.apache.org for [email protected]
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
