AlexStocks commented on a change in pull request #708:
URL: https://github.com/apache/dubbo-go/pull/708#discussion_r469148677
##########
File path: cluster/router/chain/chain.go
##########
@@ -79,6 +103,99 @@ func (c *RouterChain) AddRouters(routers
[]router.PriorityRouter) {
c.routers = newRouters
}
+// SetInvokers receives updated invokers from registry center. If the times of
notification exceeds countThreshold and
+// time interval exceeds timeThreshold since last cache update, then notify to
update the cache.
Review comment:
// If the times of notification exceeds countThreshold and time interval
exceeds timeThreshold since last cache update
why the condition type is 'and' which is not 'OR'?
##########
File path: cluster/router/chain/chain.go
##########
@@ -79,6 +103,99 @@ func (c *RouterChain) AddRouters(routers
[]router.PriorityRouter) {
c.routers = newRouters
}
+// SetInvokers receives updated invokers from registry center. If the times of
notification exceeds countThreshold and
+// time interval exceeds timeThreshold since last cache update, then notify to
update the cache.
Review comment:
// If the times of notification exceeds countThreshold and time interval
exceeds timeThreshold since last cache update
why the condition type is 'and' which is not 'OR'?
##########
File path: cluster/router/chain/chain.go
##########
@@ -79,6 +103,99 @@ func (c *RouterChain) AddRouters(routers
[]router.PriorityRouter) {
c.routers = newRouters
}
+// SetInvokers receives updated invokers from registry center. If the times of
notification exceeds countThreshold and
+// time interval exceeds timeThreshold since last cache update, then notify to
update the cache.
Review comment:
// If the times of notification exceeds countThreshold and time interval
exceeds timeThreshold since last cache update
why the condition type is 'and' which is not 'OR'?
##########
File path: cluster/router/chain/chain.go
##########
@@ -79,6 +103,99 @@ func (c *RouterChain) AddRouters(routers
[]router.PriorityRouter) {
c.routers = newRouters
}
+// SetInvokers receives updated invokers from registry center. If the times of
notification exceeds countThreshold and
+// time interval exceeds timeThreshold since last cache update, then notify to
update the cache.
Review comment:
// If the times of notification exceeds countThreshold and time interval
exceeds timeThreshold since last cache update
why the condition type is 'and' which is not 'OR'?
##########
File path: cluster/router/chain/chain.go
##########
@@ -79,6 +103,99 @@ func (c *RouterChain) AddRouters(routers
[]router.PriorityRouter) {
c.routers = newRouters
}
+// SetInvokers receives updated invokers from registry center. If the times of
notification exceeds countThreshold and
+// time interval exceeds timeThreshold since last cache update, then notify to
update the cache.
Review comment:
// If the times of notification exceeds countThreshold and time interval
exceeds timeThreshold since last cache update
why the condition type is 'and' which is not 'OR'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
