kylixs commented on a change in pull request #253:
URL: https://github.com/apache/dubbo-samples/pull/253#discussion_r555794019
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -104,13 +99,6 @@
<version>${spring-test.version}</version>
Review comment:
spring-test 改成 dependencyManagement管理版本，请参考文档
https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96
##########
File path: dubbo-samples-grpc/dubbo-samples-reactor/pom.xml
##########
@@ -35,11 +35,6 @@
<jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
<maven-failsafe-plugin.version>2.21.0</maven-failsafe-plugin.version>
Review comment:
jib, failsafe等不使用的插件的版本号去掉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
