kylixs commented on a change in pull request #259:
URL: https://github.com/apache/dubbo-samples/pull/259#discussion_r557272323
##########
File path: dubbo-samples-ssl/dubbo-samples-ssl-consumer/pom.xml
##########
@@ -28,89 +34,41 @@
<properties>
<source.level>1.8</source.level>
<target.level>1.8</target.level>
- <dubbo.version>2.7.7</dubbo.version>
- <junit.version>4.12</junit.version>
- <spring-test.version>4.3.16.RELEASE</spring-test.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
Review comment:
maven-compiler-plugin.version 这个属性不需要抽取
##########
File path: dubbo-samples-ssl/pom.xml
##########
@@ -30,4 +30,51 @@
<module>dubbo-samples-ssl-provider</module>
<module>dubbo-samples-ssl-consumer</module>
</modules>
+
+ <properties>
+ <dubbo.version>2.7.7</dubbo.version>
+ <junit.version>4.12</junit.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
Review comment:
spring 或 spring-boot 的bom放到前面
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
