kylixs commented on a change in pull request #261: URL: https://github.com/apache/dubbo-samples/pull/261#discussion_r557840339
########## File path: dubbo-samples-http/case-configuration.yml ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#from: app-builtin-zookeeper.yml Review comment: 删除多余的注释 ########## File path: dubbo-samples-http/pom.xml ########## @@ -32,43 +32,45 @@ <dubbo.version>2.7.7</dubbo.version> <spring.version>4.3.16.RELEASE</spring.version> <junit.version>4.12</junit.version> + <jackson-databind.version>2.9.5</jackson-databind.version> <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version> - <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version> <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version> Review comment: 请将 jackson、docker-maven-plugin、maven-compiler-plugin的版本号变量删除 ########## File path: dubbo-samples-http/case-configuration.yml ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +#from: app-builtin-zookeeper.yml + +props: + project_name: dubbo-samples-http + main_class: org.apache.dubbo.samples.http.HttpProvider Review comment: 单个case配置内部抽取props好像没有太大必要，会降低可读性，建议直接替换为实际值 ########## File path: dubbo-samples-http/pom.xml ########## @@ -116,149 +118,16 @@ <version>${spring.version}</version> Review comment: spring-test的版本号不需要了，由前面的spring-framework-bom管理了 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
