kylixs commented on a change in pull request #268:
URL: https://github.com/apache/dubbo-samples/pull/268#discussion_r561494864
##########
File path:
dubbo-samples-webservice/dubbo-samples-webservice-consumer/src/main/resources/spring/dubbo-samples-webservice-consumer.xml
##########
@@ -21,9 +21,9 @@
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-4.3.xsd
http://dubbo.apache.org/schema/dubbo
http://dubbo.apache.org/schema/dubbo/dubbo.xsd";>
- <dubbo:application name="demo-consumer"/>
+ <dubbo:application name="dubbo-samples-webservice-consumer"/>
- <dubbo:registry address="zookeeper://127.0.0.1:2181"/>
-
- <dubbo:reference id="demoService" check="false"
interface="org.apache.dubbo.samples.webservice.DemoService"/>
+ <dubbo:reference id="demoService" check="false" timeout="3000"
Review comment:
这里好像不需要修改，原来是从registry中获取到调用地址，只需要修改注册中心地址
```
<dubbo:registry
address="zookeeper://${zookeeper.address:127.0.0.1}:${zookeeper.port:2181}"/>
<dubbo:reference id="demoService" check="false"
interface="org.apache.dubbo.samples.webservice.DemoService"/>
```
##########
File path: dubbo-samples-webservice/dubbo-samples-webservice-provider/pom.xml
##########
@@ -24,122 +24,58 @@
<version>1.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>
-
- <groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-samples-webservice-provider</artifactId>
- <version>1.0-SNAPSHOT</version>
- <packaging>war</packaging>
-
<properties>
- <maven.compiler.source>1.8</maven.compiler.source>
- <maven.compiler.target>1.8</maven.compiler.target>
- <slf4j-log4j12.version>1.7.21</slf4j-log4j12.version>
- <servlet-api.version>2.5</servlet-api.version>
- <jsp-api.version>2.2</jsp-api.version>
- <jstl.version>1.2</jstl.version>
- <spring.version>4.3.16.RELEASE</spring.version>
- <commons-lang3.version>3.4</commons-lang3.version>
- <dubbo.version>2.7.7</dubbo.version>
- <cxf.version>3.3.7</cxf.version>
- <zookeeper.version>3.4.13</zookeeper.version>
- <curator-recipes.version>4.0.1</curator-recipes.version>
- <netty-all.version>4.1.25.Final</netty-all.version>
+ <tomcat.version>8.0.53</tomcat.version>
</properties>
-
<dependencies>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- <version>${slf4j-log4j12.version}</version>
- </dependency>
- <dependency>
- <groupId>javax.servlet</groupId>
- <artifactId>servlet-api</artifactId>
- <version>${servlet-api.version}</version>
- </dependency>
- <dependency>
- <groupId>javax.servlet.jsp</groupId>
- <artifactId>jsp-api</artifactId>
- <version>${jsp-api.version}</version>
- </dependency>
- <dependency>
- <groupId>javax.servlet</groupId>
- <artifactId>jstl</artifactId>
- <version>${jstl.version}</version>
- </dependency>
+<!-- <dependency>-->
+<!-- <groupId>javax.servlet</groupId>-->
+<!-- <artifactId>servlet-api</artifactId>-->
+<!-- </dependency>-->
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-web</artifactId>
- <version>${spring.version}</version>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-webmvc</artifactId>
- <version>${spring.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
- <version>${dubbo.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-test</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.cxf</groupId>
<artifactId>cxf-rt-frontend-simple</artifactId>
- <version>${cxf.version}</version>
- <exclusions>
- <exclusion>
- <artifactId>stax-ex</artifactId>
- <groupId>org.jvnet.staxex</groupId>
- </exclusion>
- <exclusion>
- <artifactId>javax.xml.soap-api</artifactId>
- <groupId>javax.xml.soap</groupId>
- </exclusion>
- </exclusions>
</dependency>
<dependency>
<groupId>org.apache.cxf</groupId>
<artifactId>cxf-rt-transports-http</artifactId>
- <version>${cxf.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.zookeeper</groupId>
- <artifactId>zookeeper</artifactId>
- <version>${zookeeper.version}</version>
- <exclusions>
- <exclusion>
- <artifactId>slf4j-api</artifactId>
- <groupId>org.slf4j</groupId>
- </exclusion>
- <exclusion>
- <artifactId>slf4j-log4j12</artifactId>
- <groupId>org.slf4j</groupId>
- </exclusion>
- </exclusions>
+ <groupId>org.apache.tomcat.embed</groupId>
+ <artifactId>tomcat-embed-core</artifactId>
+ <version>${tomcat.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.curator</groupId>
- <artifactId>curator-recipes</artifactId>
- <version>${curator-recipes.version}</version>
- <exclusions>
- <exclusion>
- <groupId>org.apache.zookeeper</groupId>
- <artifactId>zookeeper</artifactId>
- </exclusion>
- <exclusion>
- <artifactId>slf4j-api</artifactId>
- <groupId>org.slf4j</groupId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
- <version>${netty-all.version}</version>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-samples-webservice-interface</artifactId>
+ <version>1.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
- <artifactId>dubbo-samples-webservice-interface</artifactId>
+ <artifactId>dubbo-samples-webservice-consumer</artifactId>
Review comment:
provider 不需要依赖 dubbo-samples-webservice-consumer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
