AlexStocks commented on a change in pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#discussion_r563039385
##########
File path: common/proxy/proxy.go
##########
@@ -36,8 +36,17 @@ import (
invocation_impl "github.com/apache/dubbo-go/protocol/invocation"
)
+type Proxy interface {
Review comment:
ProxyInterface or Interface in k8s style
##########
File path: common/proxy/proxy.go
##########
@@ -36,8 +36,17 @@ import (
invocation_impl "github.com/apache/dubbo-go/protocol/invocation"
)
+type Proxy interface {
+ Implement(v common.RPCService)
+ Get() common.RPCService
+ GetCallback() interface{}
+ GetInvoker() protocol.Invoker
+}
+
+var _ Proxy = new(DefaultProxy)
+
// nolint
-type Proxy struct {
+type DefaultProxy struct {
Review comment:
Pls do not change the existing struct name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
