AlexStocks commented on a change in pull request #1010:
URL: https://github.com/apache/dubbo-go/pull/1010#discussion_r563041821
##########
File path: registry/zookeeper/listener.go
##########
@@ -142,9 +138,6 @@ func (l *RegistryConfigurationListener) Process(configType
*config_center.Config
func (l *RegistryConfigurationListener) Next() (*registry.ServiceEvent, error)
{
for {
select {
- case <-l.client.Done():
Review comment:
为何删除？
##########
File path: config_center/zookeeper/impl.go
##########
@@ -209,8 +205,6 @@ func (c *zookeeperDynamicConfiguration) closeConfigs() {
c.cltLock.Lock()
defer c.cltLock.Unlock()
logger.Infof("begin to close provider zk client")
- // Close the old client first to close the tmp node
- c.client.Close()
Review comment:
1 把上面的 log 挪到 lock 上面，减小锁粒度；
2 为何把 client.Close() 删掉了？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
