LaurenceLiZhixin commented on a change in pull request #995: URL: https://github.com/apache/dubbo-go/pull/995#discussion_r566812143
########## File path: common/dubbo_dir_refresh.go ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package common + +import "sync" + +// DirMap is used by dubbo-getty, it can notify delete event to dubbo directory directly by getty session +// look up at: +// remoting/getty/listener.go +// registry/directory/directory.go +var DirMap sync.Map Review comment: 我仔细想了想，这里的确有问题。 我写这个pr的是以：“这个session一旦被关闭，证明server端就一定关闭了”为前提的。一旦session因为网络抖动出现了err，会直接删除掉dir的cache，这样设计不太合理。 我先表述一下这个pr的初衷：是为了提高客户端对于server端下线的感知速度：不只通过regisgtry感知，而是通过session感知。如果判断窗口期请求，我觉得是不太现实，因为这个时间可能registry都通知过来了。 感觉这个需求可能有点问题。 另一方面，我的另一个pr：https://github.com/apache/dubbo-go/pull/976 有提供invoke前的健康检查机制，感觉这两个pr在功能上是有重复的，我和展图讨论下。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
